]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Clean up get_tls_handhake_key()
authorSteffan Karger <steffan@karger.me>
Mon, 22 Feb 2016 14:24:06 +0000 (15:24 +0100)
committerGert Doering <gert@greenie.muc.de>
Mon, 22 Feb 2016 15:20:22 +0000 (16:20 +0100)
commit463ea2bc90555efdcd8b2591a18aad2d47eb1d25
tree76df6c70f3ed52312711c4fbf1494657796c5699
parentb3560c98d7e4877f3ff6283dde1751654e6f7d6d
Clean up get_tls_handhake_key()

This function has *much* more code than required.  This commit cleans up
the function:
 * Merge the handling of inline and non-inline code.
 * Don't double-check key.2, since must_have_n_keys() already does that
   (but keep the message about dropped passphrase support in 2.4).
 * Remove stale references to 'passphrase' - we no longer support those

This commit should not change any behaviour except for log messages.

v2: Leave message about dropped passphrase support in place - this option
    was dropped in 2.4, so it is indeed better to be clear about it.

Signed-off-by: Steffan Karger <steffan@karger.me>
Acked-by: Arne Schwabe <arne@rfc2549.org>
Message-Id: <1456151046-16047-1-git-send-email-steffan@karger.me>
URL: http://article.gmane.org/gmane.network.openvpn.devel/11238
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/crypto.c