]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: cadence: macb: Discard pm_runtime_put() return value
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 7 Jan 2026 12:35:58 +0000 (13:35 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 8 Jan 2026 16:15:03 +0000 (08:15 -0800)
commit46786f66f2cc757a4c4787c731111372b96a847d
tree2acd95ac74240cfd390e5110c077c56790291a06
parent6961aa43654b7231ef8e1ed91cbf1da98d20ec1e
net: cadence: macb: Discard pm_runtime_put() return value

Passing pm_runtime_put() return value to the callers is not particularly
useful.

Returning an error code from pm_runtime_put() merely means that it has
not queued up a work item to check whether or not the device can be
suspended and there are many perfectly valid situations in which that
can happen, like after writing "on" to the devices' runtime PM "control"
attribute in sysfs for one example.  It also happens when the kernel is
configured with CONFIG_PM unset.

Accordingly, update at91ether_close() to simply discard the return
value of pm_runtime_put() and always return success to the caller.

This will facilitate a planned change of the pm_runtime_put() return
type to void in the future.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://patch.msgid.link/2252292.irdbgypaU6@rafael.j.wysocki
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/cadence/macb_main.c