]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Ensure maxlen is at leat 1 in dict_int
authorTomas Vondra <tomas.vondra@postgresql.org>
Tue, 3 Dec 2019 15:55:51 +0000 (16:55 +0100)
committerTomas Vondra <tomas.vondra@postgresql.org>
Tue, 3 Dec 2019 17:41:50 +0000 (18:41 +0100)
commit46ce37b67a5144458adb0789eb4e9169a61881fd
tree1a7203dcfc84d380e7650a7faf295c0c1c90f940
parent25c7183c06271b44ad2f13fc6ffe435544bee970
Ensure maxlen is at leat 1 in dict_int

The dict_int text search dictionary template accepts maxlen parameter,
which is then used to cap the length of input strings. The value was
not properly checked, and the code simply does

    txt[d->maxlen] = '\0';

to insert a terminator, leading to segfaults with negative values.

This commit simply rejects values less than 1. The issue was there since
dct_int was introduced in 9.3, so backpatch all the way back to 9.4
which is the oldest supported version.

Reported-by: cili
Discussion: https://postgr.es/m/16144-a36a5bef7657047d@postgresql.org
Backpatch-through: 9.4
contrib/dict_int/dict_int.c
contrib/dict_int/expected/dict_int.out
contrib/dict_int/sql/dict_int.sql