]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
arm64: efi: Fix handling of misaligned runtime regions and drop warning
authorArd Biesheuvel <ardb@kernel.org>
Sun, 6 Nov 2022 14:53:54 +0000 (15:53 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Nov 2022 08:57:14 +0000 (09:57 +0100)
commit475fd3991a0d98e7b43b51e64b1eb92d0a885430
tree7fb32233491a49ab304c065118367a61c0cf91f1
parent94ab8f88feb75e3b1486102c0c9c550f37d9d137
arm64: efi: Fix handling of misaligned runtime regions and drop warning

commit 9b9eaee9828fe98b030cf43ac50065a54a2f5d52 upstream.

Currently, when mapping the EFI runtime regions in the EFI page tables,
we complain about misaligned regions in a rather noisy way, using
WARN().

Not only does this produce a lot of irrelevant clutter in the log, it is
factually incorrect, as misaligned runtime regions are actually allowed
by the EFI spec as long as they don't require conflicting memory types
within the same 64k page.

So let's drop the warning, and tweak the code so that we
- take both the start and end of the region into account when checking
  for misalignment
- only revert to RWX mappings for non-code regions if misaligned code
  regions are also known to exist.

Cc: <stable@vger.kernel.org>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/arm64/kernel/efi.c