]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
[3.12] gh-121650: Encode newlines in headers, and verify headers are sound (GH-122233...
authorPetr Viktorin <encukou@gmail.com>
Tue, 6 Aug 2024 17:07:19 +0000 (19:07 +0200)
committerGitHub <noreply@github.com>
Tue, 6 Aug 2024 17:07:19 +0000 (19:07 +0200)
commit4766d1200fdf8b6728137aa2927a297e224d5fa7
treed33e20829d88f473731bb6d612e35383618ccf83
parent01db0e404de0226f106dc674981f31a6df9c19bf
[3.12] gh-121650: Encode newlines in headers, and verify headers are sound (GH-122233) (#122599)

* gh-121650: Encode newlines in headers, and verify headers are sound (GH-122233)

- Encode header parts that contain newlines

Per RFC 2047:

> [...] these encoding schemes allow the
> encoding of arbitrary octet values, mail readers that implement this
> decoding should also ensure that display of the decoded data on the
> recipient's terminal will not cause unwanted side-effects

It seems that the "quoted-word" scheme is a valid way to include
a newline character in a header value, just like we already allow
undecodable bytes or control characters.
They do need to be properly quoted when serialized to text, though.

- Verify that email headers are well-formed

This should fail for custom fold() implementations that aren't careful
about newlines.

Co-authored-by: Bas Bloemsaat <bas@bloemsaat.org>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
(cherry picked from commit 097633981879b3c9de9a1dd120d3aa585ecc2384)

* Document changes as made in 3.12.5
Doc/library/email.errors.rst
Doc/library/email.policy.rst
Doc/whatsnew/3.12.rst
Lib/email/_header_value_parser.py
Lib/email/_policybase.py
Lib/email/errors.py
Lib/email/generator.py
Lib/test/test_email/test_generator.py
Lib/test/test_email/test_policy.py
Misc/NEWS.d/next/Library/2024-07-27-16-10-41.gh-issue-121650.nf6oc9.rst [new file with mode: 0644]