]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
fs/orangefs: use snprintf() instead of sprintf()
authorAmir Mohammad Jahangirzad <a.jahangirzad@gmail.com>
Sun, 8 Jun 2025 16:35:59 +0000 (20:05 +0330)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:28:25 +0000 (16:28 +0200)
commit478bd3bc4e7f14aed79cc6220d81f87c205d462c
treeaf44323601ec4234975f05677637d7129b4bacda
parent66a373f50b4249d57f5a88c7be9676f9d5884865
fs/orangefs: use snprintf() instead of sprintf()

[ Upstream commit cdfa1304657d6f23be8fd2bb0516380a3c89034e ]

sprintf() is discouraged for use with bounded destination buffers
as it does not prevent buffer overflows when the formatted output
exceeds the destination buffer size. snprintf() is a safer
alternative as it limits the number of bytes written and ensures
NUL-termination.

Replace sprintf() with snprintf() for copying the debug string
into a temporary buffer, using ORANGEFS_MAX_DEBUG_STRING_LEN as
the maximum size to ensure safe formatting and prevent memory
corruption in edge cases.

EDIT: After this patch sat on linux-next for a few days, Dan
Carpenter saw it and suggested that I use scnprintf instead of
snprintf. I made the change and retested.

Signed-off-by: Amir Mohammad Jahangirzad <a.jahangirzad@gmail.com>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/orangefs/orangefs-debugfs.c