]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ublk: fix maple tree lockdep warning in ublk_buf_cleanup
authorMing Lei <tom.leiming@gmail.com>
Thu, 23 Apr 2026 03:30:56 +0000 (11:30 +0800)
committerJens Axboe <axboe@kernel.dk>
Thu, 23 Apr 2026 10:52:47 +0000 (04:52 -0600)
commit47903faa5c6f814f1e79b5d03708e05ca7975f6b
tree2fd1b6f4bd15a3ca119f230f19ee83b01d3f3e12
parent1cdf3b28f46dd82caca39d72e401250ee43130ba
ublk: fix maple tree lockdep warning in ublk_buf_cleanup

ublk_buf_cleanup() iterates the maple tree with mas_for_each()
without holding mas_lock, triggering a lockdep splat on
CONFIG_PROVE_RCU kernels since mas_find() internally uses
rcu_dereference_check() which requires either RCU or the tree lock.

Fix by holding mas_lock around the iteration, and call mas_erase()
before freeing each range to avoid dangling pointers in the tree.

Fixes: 5e864438e285 ("ublk: replace xarray with IDA for shmem buffer index allocation")
Reported-by: Jens Axboe <axboe@kernel.dk>
Closes: https://lore.kernel.org/linux-block/0349d72d-dff8-4f9f-b448-919fa5ae96da@kernel.dk/
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Link: https://patch.msgid.link/20260423033058.2805135-2-tom.leiming@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/ublk_drv.c