]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
vfio: Fix ksize arg while copying user struct in vfio_df_ioctl_bind_iommufd()
authorRaghavendra Rao Ananta <rananta@google.com>
Fri, 31 Oct 2025 17:06:02 +0000 (17:06 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 2 Jan 2026 11:57:28 +0000 (12:57 +0100)
commit479af0d9c6ba2fc238ceb2e1b704d3335f0428d8
tree72984a767f170ad9156d13c7760f17eb3e92a137
parent8716a841d1da4113e757b537b7d249c29d82e6db
vfio: Fix ksize arg while copying user struct in vfio_df_ioctl_bind_iommufd()

commit 2f03f21fe7516902283b135de272d3c7b10672de upstream.

For the cases where user includes a non-zero value in 'token_uuid_ptr'
field of 'struct vfio_device_bind_iommufd', the copy_struct_from_user()
in vfio_df_ioctl_bind_iommufd() fails with -E2BIG. For the 'minsz' passed,
copy_struct_from_user() expects the newly introduced field to be zero-ed,
which would be incorrect in this case.

Fix this by passing the actual size of the kernel struct. If working
with a newer userspace, copy_struct_from_user() would copy the
'token_uuid_ptr' field, and if working with an old userspace, it would
zero out this field, thus still retaining backward compatibility.

Fixes: 86624ba3b522 ("vfio/pci: Do vf_token checks for VFIO_DEVICE_BIND_IOMMUFD")
Cc: stable@vger.kernel.org
Signed-off-by: Raghavendra Rao Ananta <rananta@google.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20251031170603.2260022-2-rananta@google.com
Signed-off-by: Alex Williamson <alex@shazbot.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/vfio/device_cdev.c