]> git.ipfire.org Git - thirdparty/kmod.git/commit
tools: specify buffer to be size PATH_MAX
authorGrayson Nocera <gnocera@purdue.edu>
Mon, 25 Nov 2024 20:33:02 +0000 (15:33 -0500)
committerLucas De Marchi <lucas.de.marchi@gmail.com>
Fri, 3 Jan 2025 00:20:49 +0000 (18:20 -0600)
commit47bc9145fcf61ff335059ae169e144c11123ec4d
tree51c4f94575ce826b6b87a4d468b4dc1761b37418
parent235a38bf51ee21e73de0110d7d22894f308920b9
tools: specify buffer to be size PATH_MAX

Using a CodeQL query, I discovered that the destination of a `sscanf` call could overflow.
Thus, we bound the buffer size to be PATH_MAX, to ensure that it is
not larger than `modname` or `devname`.

Signed-off-by: Grayson Nocera <gnocera@purdue.edu>
Suggested-by: Tobias Stoeckmann <tobias@stoeckmann.org>
Link: https://github.com/kmod-project/kmod/pull/260
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
tools/static-nodes.c