]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
soc: fsl: qe: fix static checker warning
authorMaxim Kochetkov <fido_max@inbox.ru>
Wed, 11 Aug 2021 07:10:36 +0000 (10:10 +0300)
committerSasha Levin <sashal@kernel.org>
Thu, 26 Aug 2021 12:35:06 +0000 (08:35 -0400)
commit47d43f06fd879d66cfba77ea20111be48ceece0b
tree7b277eca0a0c2c9a27d3dff6e1a420ad030c905d
parent5eb70221eb037965cc11d747c9eb9030902920c6
soc: fsl: qe: fix static checker warning

[ Upstream commit c1e64c0aec8cb0499e61af7ea086b59abba97945 ]

The patch be7ecbd240b2: "soc: fsl: qe: convert QE interrupt
controller to platform_device" from Aug 3, 2021, leads to the
following static checker warning:

drivers/soc/fsl/qe/qe_ic.c:438 qe_ic_init()
warn: unsigned 'qe_ic->virq_low' is never less than zero.

In old variant irq_of_parse_and_map() returns zero if failed so
unsigned int for virq_high/virq_low was ok.
In new variant platform_get_irq() returns negative error codes
if failed so we need to use int for virq_high/virq_low.

Also simplify high_handler checking and remove the curly braces
to make checkpatch happy.

Fixes: be7ecbd240b2 ("soc: fsl: qe: convert QE interrupt controller to platform_device")
Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Li Yang <leoyang.li@nxp.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/soc/fsl/qe/qe_ic.c