]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Detect unused steps in isolation specs and do some cleanup
authorMichael Paquier <michael@paquier.xyz>
Thu, 17 Jun 2021 02:57:44 +0000 (11:57 +0900)
committerMichael Paquier <michael@paquier.xyz>
Thu, 17 Jun 2021 02:57:44 +0000 (11:57 +0900)
commit484c81bf7765862a02a2866466b140a097e36c8c
tree9c46d8d7800887b7663a88c6c9722b1e1751c01d
parentb7cd5c5b02fa38c2f2ae9a0a3642c46e625e1b97
Detect unused steps in isolation specs and do some cleanup

This is useful for developers to find out if an isolation spec is
over-engineered or if it needs more work by warning at the end of a
test run if a step is not used, generating a failure with extra diffs.

While on it, clean up all the specs which include steps not used in any
permutations to simplify them.

This is a backpatch of 989d23b and 06fdc4e, as it is becoming useful to
make all the branches consistent for an upcoming patch that will improve
the output generated by isolationtester.

Author: Michael Paquier
Reviewed-by: Asim Praveen, Melanie Plageman
Discussion: https://postgr.es/m/20190819080820.GG18166@paquier.xyz
Discussion: https://postgr.es/m/794820.1623872009@sss.pgh.pa.us
Backpatch-through: 9.6
12 files changed:
contrib/test_decoding/specs/concurrent_ddl_dml.spec
contrib/test_decoding/specs/snapshot_transfer.spec
src/test/isolation/expected/eval-plan-qual-trigger.out
src/test/isolation/isolationtester.c
src/test/isolation/isolationtester.h
src/test/isolation/specparse.y
src/test/isolation/specs/eval-plan-qual-trigger.spec
src/test/isolation/specs/freeze-the-dead.spec
src/test/isolation/specs/insert-conflict-do-nothing.spec
src/test/isolation/specs/insert-conflict-do-update-2.spec
src/test/isolation/specs/insert-conflict-do-update.spec
src/test/isolation/specs/tuplelock-upgrade-no-deadlock.spec