]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
l2tp: fix incorrect parameter validation in the pppol2tp_getsockopt() function
authorGavrilov Ilia <Ilia.Gavrilov@infotecs.ru>
Thu, 7 Mar 2024 14:23:50 +0000 (14:23 +0000)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:19:40 +0000 (18:19 -0400)
commit4865e9fb565c85799bc1fd0a6187171774f6414c
tree01d179d4f48f5150891138be66f88134587fa684
parente82ae490a9cdc3319f082acc34eee3a86af2c01f
l2tp: fix incorrect parameter validation in the pppol2tp_getsockopt() function

[ Upstream commit 955e9876ba4ee26eeaab1b13517f5b2c88e73d55 ]

The 'len' variable can't be negative when assigned the result of
'min_t' because all 'min_t' parameters are cast to unsigned int,
and then the minimum one is chosen.

To fix the logic, check 'len' as read from 'optlen',
where the types of relevant variables are (signed) int.

Fixes: 3557baabf280 ("[L2TP]: PPP over L2TP driver core")
Reviewed-by: Tom Parkin <tparkin@katalix.com>
Signed-off-by: Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/l2tp/l2tp_ppp.c