]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: rps: fix cpu unplug
authorEric Dumazet <edumazet@google.com>
Fri, 16 Jan 2015 01:04:22 +0000 (17:04 -0800)
committerJiri Slaby <jslaby@suse.cz>
Tue, 10 Feb 2015 10:16:48 +0000 (11:16 +0100)
commit488070c6dbd92ba5431f54fabb2101d09e3a018c
tree470ad4813c3f124881303376846558fb6ec37143
parent7c82148b3715206c5ffea1ffde27e5f44fa30363
net: rps: fix cpu unplug

[ Upstream commit ac64da0b83d82abe62f78b3d0e21cca31aea24fa ]

softnet_data.input_pkt_queue is protected by a spinlock that
we must hold when transferring packets from victim queue to an active
one. This is because other cpus could still be trying to enqueue packets
into victim queue.

A second problem is that when we transfert the NAPI poll_list from
victim to current cpu, we absolutely need to special case the percpu
backlog, because we do not want to add complex locking to protect
process_queue : Only owner cpu is allowed to manipulate it, unless cpu
is offline.

Based on initial patch from Prasad Sodagudi & Subash Abhinov
Kasiviswanathan.

This version is better because we do not slow down packet processing,
only make migration safer.

Reported-by: Prasad Sodagudi <psodagud@codeaurora.org>
Reported-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Tom Herbert <therbert@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
net/core/dev.c