]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-34588: Fix an off-by-one error in traceback formatting. (GH-9077)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Mon, 10 Sep 2018 16:00:08 +0000 (09:00 -0700)
committerGitHub <noreply@github.com>
Mon, 10 Sep 2018 16:00:08 +0000 (09:00 -0700)
commit49020174305ca3dc90a811b03a05f44873297c61
treefd2e3a946864286ffff75559a8a5d93ab4f36d68
parentd53f1cabe8837697df4acb70c9c6537461b5eeda
bpo-34588: Fix an off-by-one error in traceback formatting. (GH-9077)

The recursive frame pruning code always undercounted the number of elided frames
by one. That is, in the "[Previous line repeated N more times]" message, N would
always be one too few. Near the recursive pruning cutoff, one frame could be
silently dropped. That situation is demonstrated in the OP of the bug report.

The fix is to start the identical frame counter at 1.
(cherry picked from commit d545869d084e70d4838310e79b52a25a72a1ca56)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
Lib/test/test_traceback.py
Lib/traceback.py
Misc/NEWS.d/next/Core and Builtins/2018-09-05-22-56-52.bpo-34588.UIuPmL.rst [new file with mode: 0644]
Python/traceback.c