]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
libata: make ata_eh_qc_retry() bump scmd->allowed on bogus failures
authorGwendal Grignou <gwendal@google.com>
Fri, 7 Aug 2009 23:17:49 +0000 (16:17 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Nov 2013 03:01:48 +0000 (12:01 +0900)
commit49028693152b88ae7ab2d444df7f73d2f0e3bbfd
treefe22a3f75517e65011aa18755d7c310a2f9179b5
parentf49c173bb693fa2aea6c96c931f9449ce4885d7b
libata: make ata_eh_qc_retry() bump scmd->allowed on bogus failures

commit f13e220161e738c2710b9904dcb3cf8bb0bcce61 upstream.

libata EH decrements scmd->retries when the command failed for reasons
unrelated to the command itself so that, for example, commands aborted
due to suspend / resume cycle don't get penalized; however,
decrementing scmd->retries isn't enough for ATA passthrough commands.

Without this fix, ATA passthrough commands are not resend to the
drive, and no error is signalled to the caller because:

- allowed retry count is 1
- ata_eh_qc_complete fill the sense data, so result is valid
- sense data is filled with untouched ATA registers.

Signed-off-by: Gwendal Grignou <gwendal@google.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/ata/libata-eh.c