]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
spi: spi-mem: Fix inverted logic in op sanity check
authorGeert Uytterhoeven <geert+renesas@glider.be>
Tue, 25 Sep 2018 09:46:55 +0000 (11:46 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 Feb 2020 21:33:24 +0000 (16:33 -0500)
commit490ab7fce10990b91bb57d73bff57fc48ce2012b
treeb1bba7d1c403729e5c2e76ef052f0ba19e1afbe7
parentb237f078cb25e1e1819e372b8876b106d0d2dbe1
spi: spi-mem: Fix inverted logic in op sanity check

[ Upstream commit aea3877e24f3acc6145094848dbb85f9ce85674a ]

On r8a7791/koelsch:

    m25p80 spi0.0: error -22 reading 9f
    m25p80: probe of spi0.0 failed with error -22

Apparently the logic in spi_mem_check_op() is wrong, rejecting the
spi-mem operation if any buswidth is valid, instead of invalid.

Fixes: 380583227c0c7f52 ("spi: spi-mem: Add extra sanity checks on the op param")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-mem.c