]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
sched/fair: Take the scheduling domain into account in select_idle_smt()
authorKeisuke Nishimura <keisuke.nishimura@inria.fr>
Wed, 10 Jan 2024 13:17:06 +0000 (14:17 +0100)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:19:19 +0000 (18:19 -0400)
commit495b7cb952003973ff1fe4f70639bf3df91fbfb1
treef1fd6a0a5dfc82d8a1a705e6f20c3d6bd28b4569
parente42c1df34e58e2c8571ac2e9cb9ba50a48faa7d4
sched/fair: Take the scheduling domain into account in select_idle_smt()

[ Upstream commit 8aeaffef8c6eceab0e1498486fdd4f3dc3b7066c ]

When picking a CPU on task wakeup, select_idle_smt() has to take
into account the scheduling domain of @target. This is because the
"isolcpus" kernel command line option can remove CPUs from the domain to
isolate them from other SMT siblings.

This fix checks if the candidate CPU is in the target scheduling domain.

Commit:

  df3cb4ea1fb6 ("sched/fair: Fix wrong cpu selecting from isolated domain")

... originally introduced this fix by adding the check of the scheduling
domain in the loop.

However, commit:

  3e6efe87cd5cc ("sched/fair: Remove redundant check in select_idle_smt()")

... accidentally removed the check. Bring it back.

Fixes: 3e6efe87cd5c ("sched/fair: Remove redundant check in select_idle_smt()")
Signed-off-by: Keisuke Nishimura <keisuke.nishimura@inria.fr>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Link: https://lore.kernel.org/r/20240110131707.437301-1-keisuke.nishimura@inria.fr
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/sched/fair.c