]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix unsafe access to BufferDescriptors
authorRichard Guo <rguo@postgresql.org>
Wed, 19 Feb 2025 02:05:35 +0000 (11:05 +0900)
committerRichard Guo <rguo@postgresql.org>
Wed, 19 Feb 2025 02:08:39 +0000 (11:08 +0900)
commit49a450892a3e65619287c099d4b2493ae61aea9b
tree9ff1bd64abf4fc0fad9dff553c864d42c87a50ec
parent727bc6ac33f63245167b34e553c452c65c7c6d7d
Fix unsafe access to BufferDescriptors

When considering a local buffer, the GetBufferDescriptor() call in
BufferGetLSNAtomic() would be retrieving a shared buffer with a bad
buffer ID.  Since the code checks whether the buffer is shared before
using the retrieved BufferDesc, this issue did not lead to any
malfunction.  Nonetheless this seems like trouble waiting to happen,
so fix it by ensuring that GetBufferDescriptor() is only called when
we know the buffer is shared.

Author: Tender Wang <tndrwang@gmail.com>
Reviewed-by: Xuneng Zhou <xunengzhou@gmail.com>
Reviewed-by: Richard Guo <guofenglinux@gmail.com>
Discussion: https://postgr.es/m/CAHewXNku-o46-9cmUgyv6LkSZ25doDrWq32p=oz9kfD8ovVJMg@mail.gmail.com
Backpatch-through: 13
src/backend/storage/buffer/bufmgr.c