]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
gpio: GPIOHANDLE_GET_LINE_VALUES_IOCTL: Fix information leak
authorLars-Peter Clausen <lars@metafoo.de>
Tue, 18 Oct 2016 14:54:02 +0000 (16:54 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Nov 2016 15:38:45 +0000 (16:38 +0100)
commit49bdfb21e37d786e0426d00665c9db9a926cce24
treec86b9b0041441335eb43d17eac9f39745cceef21
parente22edf53b40fabd70ed61d4c1d1f6dc4cfdbb8ef
gpio: GPIOHANDLE_GET_LINE_VALUES_IOCTL: Fix information leak

commit 3eded5d83bf4e36ad78775c7ceb44a45480b0abd upstream.

The GPIOHANDLE_GET_LINE_VALUES_IOCTL handler allocates a gpiohandle_data
struct on the stack and then passes it to copy_to_user(). But depending on
the number of requested line handles the struct is only partially
initialized.

This exposes the previous, potentially sensitive, stack content to the
issuing userspace application. To avoid this make sure that the struct is
fully initialized.

Fixes: d7c51b47ac11 ("gpio: userspace ABI for reading/writing GPIO lines")
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpio/gpiolib.c