]> git.ipfire.org Git - thirdparty/linux.git/commit
cxl/region: Fix an ERR_PTR() vs NULL bug
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 18 Jul 2025 21:22:40 +0000 (16:22 -0500)
committerDave Jiang <dave.jiang@intel.com>
Fri, 18 Jul 2025 22:05:39 +0000 (15:05 -0700)
commit49d6e658e758e42aaff8ae5ecdd2d06b29abf53e
tree51eb74251c4938cfab787b84e6d44c07e0f8f96f
parent3796f2985c267b90052613cf0b379e51c61e9367
cxl/region: Fix an ERR_PTR() vs NULL bug

The __cxl_decoder_detach() function is expected to return NULL on error
but this error path accidentally returns an error pointer.  It could
potentially lead to an error pointer dereference in the caller.  Change
it to return NULL.

Fixes: b3a88225519c ("cxl/region: Consolidate cxl_decoder_kill_region() and cxl_region_detach()")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/7def7da0-326a-410d-8c92-718c8963c0a2@sabinyo.mountain
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
drivers/cxl/core/region.c