]> git.ipfire.org Git - thirdparty/glibc.git/commit
libio: Update internal fmemopen position after write (BZ #20005)
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>
Tue, 26 Apr 2016 20:40:25 +0000 (17:40 -0300)
committerMike Frysinger <vapier@gentoo.org>
Sat, 12 Nov 2016 05:44:34 +0000 (00:44 -0500)
commit4a003be3ae533aedb3f5c79424ba046f3bb0af77
treeb07519b58ef90aee12da25fd736ac45475934ba5
parent7331d984691b31a1c43bae54f4596a37fd9e7dcb
libio: Update internal fmemopen position after write (BZ #20005)

Current GLIBC fmemopen fails with a simple testcase:

  char buffer[500] = "x";
  FILE *stream;
  stream = fmemopen(buffer, 500, "r+");
  fwrite("fish",sizeof(char),5,stream);
  printf("pos-1:%ld\n",ftell(stream));
  fflush(stream);
  printf("pos-2:%ld\n",ftell(stream));

It returns:

  pos-1:5
  pos-2:0

Where it should return:

  pos-1:5
  pos-2:5

This is due the internal write function does not correctly update the internal
object position state and then the seek operation returns a wrong value.  This
patch fixes it.

It fixes both BZ #20005 and BZ #19230 (marked as duplicated). A new test is
added to check for such case.

Tested on x86_64 and i686.

This is a backport of f9123b5003e62b6e54996076e860f23aee9a0593.

* libio/fmemopen.c (fmemopen_write): Update internal position after
write.
* stdio-common/Makefile (tests): Add tst-fmemopen4.c.
* stdio-common/tst-fmemopen4.c: New file..

(cherry picked from commit c2fba3b047c2fac50985a47ff96075b5d9078432)
libio/fmemopen.c
stdio-common/Makefile
stdio-common/tst-fmemopen4.c [new file with mode: 0644]