]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ASoC: cs35l56: Must clear HALO_STATE before issuing SYSTEM_RESET
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Fri, 16 Feb 2024 14:05:35 +0000 (14:05 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 6 Mar 2024 14:48:37 +0000 (14:48 +0000)
commit4a7f5eff429bae97268a96c040b313d684508212
treece26cf2d4546545e72ed80c094f24c777ec1470f
parentfbca8bae1ba79d443a58781b45e92a73a24ac8f8
ASoC: cs35l56: Must clear HALO_STATE before issuing SYSTEM_RESET

[ Upstream commit e33625c84b75e4f078d7f9bf58f01fe71ab99642 ]

The driver must write 0 to HALO_STATE before sending the SYSTEM_RESET
command to the firmware.

HALO_STATE is in DSP memory, which is preserved across a soft reset.
The SYSTEM_RESET command does not change the value of HALO_STATE.
There is period of time while the CS35L56 is resetting, before the
firmware has started to boot, where a read of HALO_STATE will return
the value it had before the SYSTEM_RESET. If the driver does not
clear HALO_STATE, this would return BOOT_DONE status even though the
firmware has not booted.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 8a731fd37f8b ("ASoC: cs35l56: Move utility functions to shared file")
Link: https://msgid.link/r/20240216140535.1434933-1-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/codecs/cs35l56-shared.c