]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
platform/x86: dell-smbios-wmi: Add missing kfree in error-exit from run_smbios_call
authorHans de Goede <hdegoede@redhat.com>
Thu, 26 Aug 2021 14:08:22 +0000 (16:08 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 18 Sep 2021 11:41:56 +0000 (13:41 +0200)
commit4a8fe282c15ae15b754efd8157154d3553fd2699
treef519c2082589f8899acd82d573f6e9ef7e6b550c
parent97d5cb6ab801ede1f5b2bff423a302adcb3b0c52
platform/x86: dell-smbios-wmi: Add missing kfree in error-exit from run_smbios_call

[ Upstream commit 0487d4fc42d7f31a56cfd9e2237f9ebd889e6112 ]

As pointed out be Kees Cook if we return -EIO because the
obj->type != ACPI_TYPE_BUFFER, then we must kfree the
output buffer before the return.

Fixes: 1a258e670434 ("platform/x86: dell-smbios-wmi: Add new WMI dispatcher driver")
Reported-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210826140822.71198-1-hdegoede@redhat.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/platform/x86/dell/dell-smbios-wmi.c