]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
dmaengine: omap-dma: Fix memory leak when terminating running transfer
authorPeter Ujfalusi <peter.ujfalusi@ti.com>
Fri, 27 Mar 2015 11:35:52 +0000 (13:35 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 19 Apr 2015 08:10:20 +0000 (10:10 +0200)
commit4acc3ce12dcb60340212059818f7810cdd8e4335
tree7adb0bcd9edfa01780742d628d1a39fa8fea4814
parent56e1c4b3236721b26f059d0f331e2464a5d68fd7
dmaengine: omap-dma: Fix memory leak when terminating running transfer

commit 02d88b735f5a60f04dbf6d051b76e1877a0d0844 upstream.

In omap_dma_start_desc the vdesc->node is removed from the virt-dma
framework managed lists (to be precise from the desc_issued list).
If a terminate_all comes before the transfer finishes the omap_desc will
not be freed up because it is not in any of the lists and we stopped the
DMA channel so the transfer will not going to complete.
There is no special sequence for leaking memory when using cyclic (audio)
transfer: with every start and stop of a cyclic transfer the driver leaks
struct omap_desc worth of memory.

Free up the allocated memory directly in omap_dma_terminate_all() since the
framework will not going to do that for us.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
CC: <linux-omap@vger.kernel.org>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/dma/omap-dma.c