]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
jbd2: check superblock mapped prior to committing
authorJiufei Xue <jiufei.xue@linux.alibaba.com>
Sat, 6 Apr 2019 22:57:40 +0000 (18:57 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 23 Sep 2019 20:11:39 +0000 (21:11 +0100)
commit4b0b903e98c56574420b6c460aefbbf66f3ce31c
treef31bfd0dd68146259488187eef58a40535c767ff
parent57b9ed53b9ade4b1bb4950eafd21ccb0fb46a6db
jbd2: check superblock mapped prior to committing

commit 742b06b5628f2cd23cb51a034cb54dc33c6162c5 upstream.

We hit a BUG at fs/buffer.c:3057 if we detached the nbd device
before unmounting ext4 filesystem.

The typical chain of events leading to the BUG:
jbd2_write_superblock
  submit_bh
    submit_bh_wbc
      BUG_ON(!buffer_mapped(bh));

The block device is removed and all the pages are invalidated. JBD2
was trying to write journal superblock to the block device which is
no longer present.

Fix this by checking the journal superblock's buffer head prior to
submitting.

Reported-by: Eric Ren <renzhen@linux.alibaba.com>
Signed-off-by: Jiufei Xue <jiufei.xue@linux.alibaba.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Jan Kara <jack@suse.cz>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/jbd2/journal.c