]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
um: virtio_uml: Fix broken device handling in time-travel
authorJohannes Berg <johannes.berg@intel.com>
Tue, 17 May 2022 20:52:50 +0000 (22:52 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jun 2022 08:26:26 +0000 (10:26 +0200)
commit4bee45580f6ddf88ad9170b477ad3283cbbdec69
tree86b323e9c0a4b2e7f161d4a0e7126894dcf3c2cd
parent591ff9bffec99ca94c725768bfa3c7ff59655b8a
um: virtio_uml: Fix broken device handling in time-travel

commit af9fb41ed315ce95f659f0b10b4d59a71975381d upstream.

If a device implementation crashes, virtio_uml will mark it
as dead by calling virtio_break_device() and scheduling the
work that will remove it.

This still seems like the right thing to do, but it's done
directly while reading the message, and if time-travel is
used, this is in the time-travel handler, outside of the
normal Linux machinery. Therefore, we cannot acquire locks
or do normal "linux-y" things because e.g. lockdep will be
confused about the context.

Move handling this situation out of the read function and
into the actual IRQ handler and response handling instead,
so that in the case of time-travel we don't call it in the
wrong context.

Chances are the system will still crash immediately, since
the device implementation crashing may also cause the time-
travel controller to go down, but at least all of that now
happens without strange warnings from lockdep.

Fixes: c8177aba37ca ("um: time-travel: rework interrupt handling in ext mode")
Cc: stable@vger.kernel.org
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/um/drivers/virtio_uml.c