]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
dm bufio: fix memleak when using a dm_buffer's inline bio
authorDarrick J. Wong <darrick.wong@oracle.com>
Wed, 26 Nov 2014 01:45:15 +0000 (17:45 -0800)
committerJiri Slaby <jslaby@suse.cz>
Wed, 7 Jan 2015 15:24:10 +0000 (16:24 +0100)
commit4c0c560de59bf1f8a97bf76086c15c70dd3181db
treef5abf0f8bfd29fe629015342cfbce68a90d1c6e0
parentebccfce81acf2c023ae5adeddd7612ef2351c421
dm bufio: fix memleak when using a dm_buffer's inline bio

commit 445559cdcb98a141f5de415b94fd6eaccab87e6d upstream.

When dm-bufio sets out to use the bio built into a struct dm_buffer to
issue an IO, it needs to call bio_reset after it's done with the bio
so that we can free things attached to the bio such as the integrity
payload.  Therefore, inject our own endio callback to take care of
the bio_reset after calling submit_io's end_io callback.

Test case:
1. modprobe scsi_debug delay=0 dif=1 dix=199 ato=1 dev_size_mb=300
2. Set up a dm-bufio client, e.g. dm-verity, on the scsi_debug device
3. Repeatedly read metadata and watch kmalloc-192 leak!

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/md/dm-bufio.c