]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
iio: itg3200: Call iio_trigger_notify_done() on error
authorLars-Peter Clausen <lars@metafoo.de>
Mon, 1 Nov 2021 14:40:54 +0000 (15:40 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Dec 2021 13:49:05 +0000 (14:49 +0100)
commit4c0fa7ed5a3a6ed56be8a6a52704cbd1d83fb0c2
treefa3c400fe38f796d74db8c8726f49512d76fe452
parente67d60c5ebb0b7bc34882ef987acad748b3713e8
iio: itg3200: Call iio_trigger_notify_done() on error

commit 67fe29583e72b2103abb661bb58036e3c1f00277 upstream.

IIO trigger handlers must call iio_trigger_notify_done() when done. This
must be done even when an error occurred. Otherwise the trigger will be
seen as busy indefinitely and the trigger handler will never be called
again.

The itg3200 driver neglects to call iio_trigger_notify_done() when there is
an error reading the gyro data. Fix this by making sure that
iio_trigger_notify_done() is included in the error exit path.

Fixes: 9dbf091da080 ("iio: gyro: Add itg3200")
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20211101144055.13858-1-lars@metafoo.de
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/gyro/itg3200_buffer.c