]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: dsa: mt7530: fix null pointer dereferencing in port5 setup
authorChuanhong Guo <gch981213@gmail.com>
Fri, 3 Apr 2020 11:28:24 +0000 (19:28 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Apr 2020 11:16:29 +0000 (13:16 +0200)
commit4c0fc5b184fc589b7b993411a7162f72c4660593
tree049d34afe060c01428da97736fa456c8eec7e5e7
parente02afb9be9f72d5c2c3b9248638d56939300086b
net: dsa: mt7530: fix null pointer dereferencing in port5 setup

[ Upstream commit 0452800f6db4ed0a42ffb15867c0acfd68829f6a ]

The 2nd gmac of mediatek soc ethernet may not be connected to a PHY
and a phy-handle isn't always available.
Unfortunately, mt7530 dsa driver assumes that the 2nd gmac is always
connected to switch port 5 and setup mt7530 according to phy address
of 2nd gmac node, causing null pointer dereferencing when phy-handle
isn't defined in dts.
This commit fix this setup code by checking return value of
of_parse_phandle before using it.

Fixes: 38f790a80560 ("net: dsa: mt7530: Add support for port 5")
Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
Reviewed-by: Vivien Didelot <vivien.didelot@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: René van Dorst <opensource@vdorst.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/dsa/mt7530.c