]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ALSA: als4000: Fix capture trigger chip->mode race
authorCássio Gabriel <cassiogabrielcontato@gmail.com>
Fri, 17 Apr 2026 20:30:18 +0000 (17:30 -0300)
committerTakashi Iwai <tiwai@suse.de>
Mon, 20 Apr 2026 15:59:19 +0000 (17:59 +0200)
commit4cc3ec3d8b3536f2293a5a984c28ba2a09e8b22d
tree116aeda94ea66a0509cc9f2a565a40035b579aeb
parent8146cd333d235ed32d48bb803fdf743472d7c783
ALSA: als4000: Fix capture trigger chip->mode race

snd_als4000_capture_trigger() updates chip->mode under mixer_lock,
while snd_als4000_set_rate() and snd_als4000_playback_trigger()
serialize the same rate-lock state with reg_lock.

The PCM core serializes callbacks only per acted-on substream, or for an
explicitly linked group, so unlinked playback and capture streams can
run concurrently.

That leaves two races on ALS4000 rate-lock state:
- playback and capture trigger callbacks can concurrently update
  chip->mode and lose one of the SB_RATE_LOCK bits
- snd_als4000_set_rate() can observe chip->mode without the capture
  lock bit set and reprogram the shared sample rate while capture is
  being started

Fix this by taking reg_lock as the outer lock in
snd_als4000_capture_trigger() and nesting mixer_lock only for the CR1E
write. This keeps chip->mode serialized with the rest of the ALS4000
rate-lock users while preserving the existing CR1E programming
sequence.

Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Link: https://patch.msgid.link/20260417-als4000-capture-trigger-race-v1-1-daeffc2feb67@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/als4000.c