]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Reduce risks of conflicts in internal queries of REFRESH MATVIEW CONCURRENTLY
authorMichael Paquier <michael@paquier.xyz>
Thu, 3 Jun 2021 06:28:41 +0000 (15:28 +0900)
committerMichael Paquier <michael@paquier.xyz>
Thu, 3 Jun 2021 06:28:41 +0000 (15:28 +0900)
commit4ceaa760bd8cf0e19f513a9b6fdf503037d8ff72
tree86d24ee1b84ed3ea9efb2723407ed242a4be5734
parentebd542bf4fd3dc8e9f2c8f145b57eccfd498a003
Reduce risks of conflicts in internal queries of REFRESH MATVIEW CONCURRENTLY

The internal SQL queries used by REFRESH MATERIALIZED VIEW CONCURRENTLY
include some aliases for its diff and temporary relations with
rather-generic names: diff, newdata, newdata2 and mv.  Depending on the
queries used for the materialized view, using CONCURRENTLY could lead to
some internal failures if the query and those internal aliases conflict.

Those names have been chosen in 841c29c8.  This commit switches instead
to a naming pattern which is less likely going to cause conflicts, based
on an idea from Thomas Munro, by appending _$ to those aliases.  This is
not perfect as those new names could still conflict, but at least it has
the advantage to keep the code readable and simple while reducing the
likelihood of conflicts to be close to zero.

Reported-by: Mathis Rudolf
Author: Bharath Rupireddy
Reviewed-by: Bernd Helmle, Thomas Munro, Michael Paquier
Discussion: https://postgr.es/m/109c267a-10d2-3c53-b60e-720fcf44d9e8@credativ.de
Backpatch-through: 9.6
src/backend/commands/matview.c