]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
sg_start_req(): make sure that there's not too many elements in iovec
authorAl Viro <viro@zeniv.linux.org.uk>
Sun, 22 Mar 2015 00:08:18 +0000 (20:08 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Aug 2015 03:51:41 +0000 (20:51 -0700)
commit4d0dd4350a4107265fd8701d4b26fdc033ad28cc
tree68b95a85c7426cf08432451fb39f71f39333a2c2
parentc4a6d3f3491a55269ee1e8d99f6fa7bab15cc011
sg_start_req(): make sure that there's not too many elements in iovec

commit 451a2886b6bf90e2fb378f7c46c655450fb96e81 upstream.

unfortunately, allowing an arbitrary 16bit value means a possibility of
overflow in the calculation of total number of pages in bio_map_user_iov() -
we rely on there being no more than PAGE_SIZE members of sum in the
first loop there.  If that sum wraps around, we end up allocating
too small array of pointers to pages and it's easy to overflow it in
the second loop.

X-Coverup: TINC (and there's no lumber cartel either)
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
[bwh: s/MAX_UIOVEC/UIO_MAXIOV/. This was fixed upstream by commit
 fdc81f45e9f5 ("sg_start_req(): use import_iovec()"), but we don't have
  that function.]
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/sg.c