]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: ufs: Fix unbalanced scsi_block_reqs_cnt caused by ufshcd_hold()
authorCan Guo <cang@codeaurora.org>
Tue, 3 Nov 2020 06:24:39 +0000 (22:24 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Nov 2020 12:27:19 +0000 (13:27 +0100)
commit4d3413ba2360363f77fa133af128a3034203a021
tree0a2356d51c80d310031b494223a584406f41b716
parent6c5f86abc3b58054455f23eaee5537dba353c8d6
scsi: ufs: Fix unbalanced scsi_block_reqs_cnt caused by ufshcd_hold()

[ Upstream commit da3fecb0040324c08f1587e5bff1f15f36be1872 ]

The scsi_block_reqs_cnt increased in ufshcd_hold() is supposed to be
decreased back in ufshcd_ungate_work() in a paired way. However, if
specific ufshcd_hold/release sequences are met, it is possible that
scsi_block_reqs_cnt is increased twice but only one ungate work is
queued. To make sure scsi_block_reqs_cnt is handled by ufshcd_hold() and
ufshcd_ungate_work() in a paired way, increase it only if queue_work()
returns true.

Link: https://lore.kernel.org/r/1604384682-15837-2-git-send-email-cang@codeaurora.org
Reviewed-by: Hongwu Su <hongwus@codeaurora.org>
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Bean Huo <beanhuo@micron.com>
Signed-off-by: Can Guo <cang@codeaurora.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/ufs/ufshcd.c