]> git.ipfire.org Git - thirdparty/linux.git/commit
comedi: ni_*: do not declare unused variable range_ni_E_ao_ext
authorIan Abbott <abbotti@mev.co.uk>
Wed, 10 Jul 2024 17:37:19 +0000 (18:37 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 31 Jul 2024 11:11:43 +0000 (13:11 +0200)
commit4d41a49c4660eca5214d8b6f85cc8569c7d77599
treecc15640e58ebe4bf98e9e4ad132274297618986f
parent8400291e289ee6b2bf9779ff1c83a291501f017b
comedi: ni_*: do not declare unused variable range_ni_E_ao_ext

Mirsad Todorovac reported a compiler warning in "ni_stc.h" due to the
variable `range_ni_E_ao_ext` being defined but unused when building the
"ni_routes_test" module.

The `range_ni_E_ao_ext` variable is tentatively defined in "ni_stc.h"
(with internal linkage) and fully defined in "ni_mio_common.c".
"ni_stc.h" and/or "ni_mio_common.c" are included by the "ni_atmio",
"ni_pcimio", "ni_mio_cs", and "ni_routes_test" modules, which will each
get their own local `range_ni_E_ao_ext` variable defined.  However, it
is not used by the "ni_mio_cs" or "ni_routes_test" modules.  They should
get optimized out, but there are compiler warnings about the unused
variable when built with the `W=1` option.

Move the full definition of the variable from "ni_mio_common.c" into the
places where it is used, namely "ni_atmio.c" and "ni_pcimio.c", and
remove the tentative definition of the variable from "ni_stc.h".  This
fixes the compiler warnings.

Reported-by: Mirsad Todorovac <mtodorovac69@gmail.com>
Link: https://lore.kernel.org/lkml/3bab8580-c01a-4183-94af-ba3193c94c0e@gmail.com/
Cc: Mirsad Todorovac <mtodorovac69@gmail.com>
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://lore.kernel.org/r/20240710173719.3559437-1-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/comedi/drivers/ni_atmio.c
drivers/comedi/drivers/ni_mio_common.c
drivers/comedi/drivers/ni_pcimio.c
drivers/comedi/drivers/ni_stc.h