]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/xe/xe_guc_submit: Fix exec queue stop race condition
authorJonathan Cavitt <jonathan.cavitt@intel.com>
Fri, 10 May 2024 19:45:38 +0000 (12:45 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Aug 2024 13:34:13 +0000 (15:34 +0200)
commit4d4604ebf8ac3d2b06e46eb1318edbe594ef1f8a
tree2f34e712693701520290fae868ea09fa659e9865
parent4c59fc86bf28c3217a4cec7736da824d527ffb53
drm/xe/xe_guc_submit: Fix exec queue stop race condition

[ Upstream commit 1564d411e17f51e2f64655b4e4da015be1ba7eaa ]

Reorder the xe_sched_tdr_queue_imm and set_exec_queue_banned calls in
guc_exec_queue_stop.  This prevents a possible race condition between
the two events in which it's possible for xe_sched_tdr_queue_imm to
wake the ufence waiter before the exec queue is banned, causing the
ufence waiter to miss the banned state.

Suggested-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Stuart Summers <stuart.summers@intel.com>
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240510194540.3246991-1-jonathan.cavitt@intel.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/xe/xe_guc_submit.c