]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
codel: remove sch->q.qlen check before qdisc_tree_reduce_backlog()
authorCong Wang <xiyou.wangcong@gmail.com>
Thu, 3 Apr 2025 21:16:31 +0000 (14:16 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 20 Apr 2025 08:15:06 +0000 (10:15 +0200)
commit4d55144b12e742404bb3f8fee6038bafbf45619d
tree5c2a18743adea48e027da8ccaa450df66ecf52f5
parent7c5957f7905b4aede9d7a559d271438f3ca9e852
codel: remove sch->q.qlen check before qdisc_tree_reduce_backlog()

[ Upstream commit 342debc12183b51773b3345ba267e9263bdfaaef ]

After making all ->qlen_notify() callbacks idempotent, now it is safe to
remove the check of qlen!=0 from both fq_codel_dequeue() and
codel_qdisc_dequeue().

Reported-by: Gerrard Tai <gerrard.tai@starlabs.sg>
Fixes: 4b549a2ef4be ("fq_codel: Fair Queue Codel AQM")
Fixes: 76e3cc126bb2 ("codel: Controlled Delay AQM")
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250403211636.166257-1-xiyou.wangcong@gmail.com
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/sched/sch_codel.c
net/sched/sch_fq_codel.c