]> git.ipfire.org Git - people/ms/linux.git/commit
V4L/DVB: Video : pwc : Fix regression in pwc_set_shutter_speed caused by bad constant...
authorMartin Fuzzey <mfuzzey@gmail.com>
Thu, 11 Feb 2010 13:50:31 +0000 (10:50 -0300)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 1 Apr 2010 22:55:54 +0000 (15:55 -0700)
commit4d87fb8a9ef88ef05b9e7ceb2bc0f86019fe1578
treeee66446f2e57ee010c8cd0c5727c9789ebff152c
parentc25e75ba38178843bd885f227d285eec53202dca
V4L/DVB: Video : pwc : Fix regression in pwc_set_shutter_speed caused by bad constant => sizeof conversion.

commit 53f68607caba85db9a73846ccd289e4b7fa96295 upstream.

Regression was caused by my commit 6b35ca0d3d586b8ecb8396821af21186e20afaf0
which determined message size using sizeof rather than hardcoded constants.

Unfortunately pwc_set_shutter_speed reuses a 2 byte buffer for a one byte
message too so the sizeof was bogus in this case.

All other uses of sizeof checked and are ok.

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Martin Fuzzey <mfuzzey@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/media/video/pwc/pwc-ctrl.c