]> git.ipfire.org Git - thirdparty/openvpn.git/commit
crypto_backend: fix type of enc parameter
authorFrank Lichtenheld <frank@lichtenheld.com>
Wed, 27 Mar 2024 16:26:21 +0000 (17:26 +0100)
committerGert Doering <gert@greenie.muc.de>
Sun, 31 Mar 2024 13:59:47 +0000 (15:59 +0200)
commit4d907bf46a470ccbd2940b9ecb64d6502d9d86bf
tree2fe98ca48bcb19ae20f14d9f22a9fa084cb5d6d9
parent4c71e816031f564f834df695b3fa717ea22720d2
crypto_backend: fix type of enc parameter

We had parts of a abstraction, but it wasn't consistent.
GCC 13 now complains about the type mismatch with mbedtls now:

crypto_mbedtls.c:568:1: error:
conflicting types for ‘cipher_ctx_init’ due to enum/integer mismatch;
have ‘void(mbedtls_cipher_context_t *, const uint8_t *, const char *, const mbedtls_operation_t)’
[...] [-Werror=enum-int-mismatch]
crypto_backend.h:341:6: note:
previous declaration of ‘cipher_ctx_init’ with type
‘void(cipher_ctx_t *, const uint8_t *, const char *, int)’ [...]

Previous compiler versions did not complain.

v2:
 - clean solution instead of quick solution. Fix the actual API
   definition

Change-Id: If0dcdde30879fd6185efb2ad31399c1629c04d22
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org>
Message-Id: <20240327162621.1792414-1-frank@lichtenheld.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28498.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/crypto_backend.h
src/openvpn/crypto_mbedtls.c
src/openvpn/crypto_mbedtls.h
src/openvpn/crypto_openssl.c
src/openvpn/crypto_openssl.h