]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
dm-snapshot: fix performance degradation due to small hash size
authorMikulas Patocka <mpatocka@redhat.com>
Wed, 18 Sep 2013 23:40:42 +0000 (19:40 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 5 Oct 2013 14:17:57 +0000 (07:17 -0700)
commit4db0b844c769081b829950887d38da97e14f5562
tree9c7ec3b4613e07a7520f11407e7f4601da05a488
parent477dd7e45fd9a5ec6304e31a2967ffe2fd1a9b7e
dm-snapshot: fix performance degradation due to small hash size

commit 60e356f381954d79088d0455e357db48cfdd6857 upstream.

LVM2, since version 2.02.96, creates origin with zero size, then loads
the snapshot driver and then loads the origin.  Consequently, the
snapshot driver sees the origin size zero and sets the hash size to the
lower bound 64.  Such small hash table causes performance degradation.

This patch changes it so that the hash size is determined by the size of
snapshot volume, not minimum of origin and snapshot size.  It doesn't
make sense to set the snapshot size significantly larger than the origin
size, so we do not need to take origin size into account when
calculating the hash size.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/md/dm-snap.c