]> git.ipfire.org Git - thirdparty/pdns.git/commit
dnsdist: Fix handling of XFR requests over DoH dnsdist-1.9.4
authorRemi Gacogne <remi.gacogne@powerdns.com>
Tue, 23 Apr 2024 13:51:35 +0000 (15:51 +0200)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Thu, 25 Apr 2024 13:10:20 +0000 (15:10 +0200)
commit4dc07fc55e007b330aa4c7a3271cb065e526363b
tree88fc497cc781c73b711e26d0c6b6a6ec159d3981
parent4a4c1016dfb40ce914273c7407afccbfceaaefcd
dnsdist: Fix handling of XFR requests over DoH

We did not properly handle incoming XFR requests received over DoH
When a TCP-only or DoT backend was configured, and the nghttp2 provider
used.
This commit fixes the assertion failure and makes sure that XFR
requests are denied with `NOTIMP` when received over DNS over HTTPS,
including DNS over HTTP/3. It also denies them when received over
DNS over QUIC as this is not properly handled at the moment, although
it does not cause a crash.
pdns/dnsdist.cc
pdns/dnsdistdist/dnsdist-nghttp2-in.cc
pdns/dnsdistdist/dnsdist-tcp-downstream.cc
regression-tests.dnsdist/quictests.py
regression-tests.dnsdist/test_DOH.py
regression-tests.dnsdist/test_DOH3.py
regression-tests.dnsdist/test_DOQ.py