]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
gve: change to use page_pool_put_full_page when recycling pages
authorHarshitha Ramamurthy <hramamurthy@google.com>
Wed, 23 Oct 2024 22:11:41 +0000 (15:11 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 31 Oct 2024 00:59:16 +0000 (17:59 -0700)
commit4ddf7ccfdf70364010005b0b695b1a0d92677425
treeeb1de096cee5f866e02ef034086628d125681b4f
parente110225ec120bb4327b442601daffe82ca514bbf
gve: change to use page_pool_put_full_page when recycling pages

The driver currently uses page_pool_put_page() to recycle
page pool pages. Since gve uses split pages, if the fragment
being recycled is not the last fragment in the page, there
is no dma sync operation. When the last fragment is recycled,
dma sync is performed by page pool infra according to the
value passed as dma_sync_size which right now is set to the
size of fragment.

But the correct thing to do is to dma sync the entire page when
the last fragment is recycled. Hence change to using
page_pool_put_full_page().

Link: https://lore.kernel.org/netdev/89d7ce83-cc1d-4791-87b5-6f7af29a031d@huawei.com/
Suggested-by: Yunsheng Lin <linyunsheng@huawei.com>
Reviewed-by: Praveen Kaligineedi <pkaligineedi@google.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Harshitha Ramamurthy <hramamurthy@google.com>
Reviewed-by: Yunsheng Lin <linyunsheng@huawei.com>
Fixes: ebdfae0d377b ("gve: adopt page pool for DQ RDA mode")
Link: https://patch.msgid.link/20241023221141.3008011-1-pkaligineedi@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c