]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tls: fix lockless read of strp->msg_ready in ->poll
authorSabrina Dubroca <sd@queasysnail.net>
Wed, 24 Apr 2024 10:25:47 +0000 (12:25 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 May 2024 14:32:40 +0000 (16:32 +0200)
commit4e40e624961a9858ac1412693987bb191ca5fe34
treefab58a62e8701b83da712bd309d2d8894d24a715
parent77df3da37d420789059374c96faac9e7cf40096c
tls: fix lockless read of strp->msg_ready in ->poll

[ Upstream commit 0844370f8945086eb9335739d10205dcea8d707b ]

tls_sk_poll is called without locking the socket, and needs to read
strp->msg_ready (via tls_strp_msg_ready). Convert msg_ready to a bool
and use READ_ONCE/WRITE_ONCE where needed. The remaining reads are
only performed when the socket is locked.

Fixes: 121dca784fc0 ("tls: suppress wakeups unless we have a full record")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Link: https://lore.kernel.org/r/0b7ee062319037cf86af6b317b3d72f7bfcd2e97.1713797701.git.sd@queasysnail.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/net/tls.h
net/tls/tls.h
net/tls/tls_strp.c