]> git.ipfire.org Git - thirdparty/postgresql.git/commit
jit: Do not try to shut down LLVM state in case of LLVM triggered errors.
authorAndres Freund <andres@anarazel.de>
Tue, 14 Sep 2021 01:07:19 +0000 (18:07 -0700)
committerAndres Freund <andres@anarazel.de>
Tue, 14 Sep 2021 01:15:28 +0000 (18:15 -0700)
commit4e86887e0922f20add67e2473c7baae8c7f05d5e
treebdfc08668a42c5fff3e173f0ac01132f32a28b2b
parent0d0bbee5e3ee2eabe3a1f6081cbc4226520764c0
jit: Do not try to shut down LLVM state in case of LLVM triggered errors.

If an allocation failed within LLVM it is not safe to call back into LLVM as
LLVM is not generally safe against exceptions / stack-unwinding. Thus errors
while in LLVM code are promoted to FATAL. However llvm_shutdown() did call
back into LLVM even in such cases, while llvm_release_context() was careful
not to do so.

We cannot generally skip shutting down LLVM, as that can break profiling. But
it's OK to do so if there was an error from within LLVM.

Reported-By: Jelte Fennema <Jelte.Fennema@microsoft.com>
Author: Andres Freund <andres@anarazel.de>
Author: Justin Pryzby <pryzby@telsasoft.com>
Discussion: https://postgr.es/m/AM5PR83MB0178C52CCA0A8DEA0207DC14F7FF9@AM5PR83MB0178.EURPRD83.prod.outlook.com
Backpatch: 11-, where jit was introduced
src/backend/jit/llvm/llvmjit.c
src/backend/jit/llvm/llvmjit_error.cpp
src/include/jit/llvmjit.h