]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Don't leak malloc'd error string in libpqrcv_check_conninfo().
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 19 Mar 2021 02:21:58 +0000 (22:21 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 19 Mar 2021 02:21:58 +0000 (22:21 -0400)
commit4eca51d4464133e6f4cd923355c6dd971d9c27d3
tree11a79a9020cbc2a497a5d03b03463a5365c2560a
parentfc552f8680a79d602beae230615ffe8ed236cc43
Don't leak malloc'd error string in libpqrcv_check_conninfo().

We leaked the error report from PQconninfoParse, when there was
one.  It seems unlikely that real usage patterns would repeat
the failure often enough to create serious bloat, but let's
back-patch anyway to keep the code similar in all branches.

Found via valgrind testing.
Back-patch to v10 where this code was added.

Discussion: https://postgr.es/m/3816764.1616104288@sss.pgh.pa.us
src/backend/replication/libpqwalreceiver/libpqwalreceiver.c