]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mtd: cfi_cmdset_0002: don't free cfi->cfiq in error path of cfi_amdstd_setup()
authorHou Tao <houtao1@huawei.com>
Tue, 8 Oct 2019 02:36:37 +0000 (10:36 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 1 Oct 2020 09:11:50 +0000 (11:11 +0200)
commit4ee4cd0be975e5e9d7e8112df34f72ed8ef06402
tree67b25e32be3599500f167d925584d5845ef6c42f
parent9fa1b9fed8ec4cc46a1f7763eda306e2389b3e3f
mtd: cfi_cmdset_0002: don't free cfi->cfiq in error path of cfi_amdstd_setup()

[ Upstream commit 03976af89e3bd9489d542582a325892e6a8cacc0 ]

Else there may be a double-free problem, because cfi->cfiq will
be freed by mtd_do_chip_probe() if both the two invocations of
check_cmd_set() return failure.

Signed-off-by: Hou Tao <houtao1@huawei.com>
Reviewed-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mtd/chips/cfi_cmdset_0002.c