]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Move protocol option negotiation from push_prepare to new function
authorArne Schwabe <arne@rfc2549.org>
Thu, 9 Jul 2020 10:15:59 +0000 (12:15 +0200)
committerGert Doering <gert@greenie.muc.de>
Fri, 10 Jul 2020 15:05:58 +0000 (17:05 +0200)
commit4f378ddb9932973965bb4931e85c991ddd86f7f0
tree6c581027e3ff3600d56ab9f581e9be2d0da30d4f
parentca514800ca126b69dbde846db819d8bf4c490e68
Move protocol option negotiation from push_prepare to new function

This clean ups the code and removes the surprising side effects
of preparing a push reply to also select protocol options.

We also remember if we have seen a push request without async
push. This improves reaction time if deferred auth is involved
like managment interface deferred auth.  The other benefit is
removing a number of ifdefs.

NOTE: this patch breaks asynchronous authentication (via plugins
and possibly also via management interface).  The next commit will
fix this.  This is understood and hereby documented, but the two
individual commits are much cleaner without trying to fix it here
or squash both together.

Signed-off-by: Arne Schwabe <arne@rfc2549.org>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20200709101603.11941-4-arne@rfc2549.org>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg20255.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/forward.c
src/openvpn/multi.c
src/openvpn/openvpn.h
src/openvpn/push.c