]> git.ipfire.org Git - thirdparty/libvirt.git/commit
domain_conf: move virDomainPCIControllerOpts checks to domain_validate.c
authorDaniel Henrique Barboza <danielhb413@gmail.com>
Fri, 4 Dec 2020 21:11:51 +0000 (18:11 -0300)
committerDaniel Henrique Barboza <danielhb413@gmail.com>
Wed, 9 Dec 2020 12:51:52 +0000 (09:51 -0300)
commit4fa54581d0c7a4e88a2ed1ce4e56752b52b4cd11
treeebf3320d53692a51508c4215636abd782c74769e
parent84da28a86d889bf74439822ea7af4016405f229b
domain_conf: move virDomainPCIControllerOpts checks to domain_validate.c

virDomainControllerDefParseXML() does a lot of checks with
virDomainPCIControllerOpts parameters that can be moved to
virDomainControllerDefValidate, sharing the logic with other use
cases that does not rely on XML parsing.

'pseries-default-phb-numa-node' parse error was changed to reflect
the error that is being thrown by qemuValidateDomainDeviceDefController()
via deviceValidateCallback, that is executed before
virDomainControllerDefValidate().

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
src/conf/domain_conf.c
src/conf/domain_validate.c
tests/qemuxml2argvdata/pseries-default-phb-numa-node.err
tests/qemuxml2argvtest.c