]> git.ipfire.org Git - thirdparty/libvirt.git/commit
conf: Drop virDomainChrDeviceType.targetTypeAttr
authorAndrea Bolognani <abologna@redhat.com>
Fri, 10 Nov 2017 13:54:19 +0000 (14:54 +0100)
committerAndrea Bolognani <abologna@redhat.com>
Tue, 28 Nov 2017 14:46:32 +0000 (15:46 +0100)
commit4fb8ff9987b7e34d331c4af8f573db11579a0e88
tree10782bd35ffae64ff26f1a642ea100896d2564f0
parent6385c8c14233388d929ed62717684e7352543416
conf: Drop virDomainChrDeviceType.targetTypeAttr

This attribute was used to decide whether to format the type
attribute of the <target> element, but the logic didn't take into
account all possible cases and as such could lead to unexpected
results. Moreover, it's one more thing to keep track of, and can
easily fall out of sync with other attributes.

Now that we have VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_NONE, we can
use that value to signal that no specific target type has been
configured for the serial device and as such the attribute should
not be formatted at all. All other values are now formatted.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
43 files changed:
src/conf/domain_conf.c
src/conf/domain_conf.h
src/vz/vz_sdk.c
tests/qemuargv2xmldata/qemuargv2xml-console-compat.xml
tests/qemuargv2xmldata/qemuargv2xml-serial-dev.xml
tests/qemuargv2xmldata/qemuargv2xml-serial-file.xml
tests/qemuargv2xmldata/qemuargv2xml-serial-many.xml
tests/qemuargv2xmldata/qemuargv2xml-serial-pty.xml
tests/qemuargv2xmldata/qemuargv2xml-serial-tcp-telnet.xml
tests/qemuargv2xmldata/qemuargv2xml-serial-tcp.xml
tests/qemuargv2xmldata/qemuargv2xml-serial-udp.xml
tests/qemuargv2xmldata/qemuargv2xml-serial-unix.xml
tests/qemuargv2xmldata/qemuargv2xml-serial-vc.xml
tests/qemuhotplugtestdomains/qemuhotplug-console-compat-2-live+console-virtio.xml
tests/qemuhotplugtestdomains/qemuhotplug-console-compat-2-live.xml
tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev-notls.xml
tests/qemuxml2argvdata/qemuxml2argv-user-aliases.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-bios-nvram-os-interleave.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-chardev-label.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat-auto.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat2.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-console-virtio-many.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-interface-driver.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-interface-server.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-net-bandwidth.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-net-bandwidth2.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-net-coalesce.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-net-mtu.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-panic-pseries.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-compat-power9.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-compat.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-cpu-exact.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-panic-missing.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-panic-no-address.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-virt-manager-basic.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-spiceport-nospice.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-spiceport.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-target-port-auto.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-tcp-tlsx509-chardev.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-tap-vhost-incorrect.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-tap-vhost.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-vhost_queues.xml