]> git.ipfire.org Git - thirdparty/linux.git/commit
lib: test_hmm: use device devt for coherent device range selection
authorStanislav Kinsburskii <skinsburskii@gmail.com>
Mon, 29 Jun 2026 23:30:14 +0000 (16:30 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 21 Jul 2026 00:41:26 +0000 (17:41 -0700)
commit4fc089235378d1f9ddb6bcbe67c192ffdcaae0ed
tree512b3ee67aac02da57d80a7a447d6b046114a7cd
parentea3034b2b00fa50c8d2518d0804c9d427bbafa86
lib: test_hmm: use device devt for coherent device range selection

Commit af69016dab96 ("lib: test_hmm: implement a device release method")
moved the initial dmirror_allocate_chunk() call before cdev_device_add().
That means the struct cdev has not been added yet, so cdev_add() has not
initialized mdevice->cdevice.dev.

The coherent-device range selection uses the device minor to choose
between spm_addr_dev0 and spm_addr_dev1.  Reading
MINOR(mdevice->cdevice.dev) before cdev_add() therefore always sees an
uninitialized dev_t.  As a result, both coherent devices select the same
physical range, and adding the second device fails due to the overlapping
dev_pagemap range.

Use mdevice->device.devt instead.  It is initialized in
dmirror_device_init() before dmirror_allocate_chunk() is called and is the
same dev_t later passed to cdev_device_add().

Link: https://lore.kernel.org/178277581197.172200.16265155329935822153.stgit@skinsburskii
Fixes: af69016dab96 ("lib: test_hmm: implement a device release method")
Signed-off-by: Stanislav Kinsburskii <skinsburskii@gmail.com>
Reviewed-by: Alistair Popple <apopple@nvidia.com>
Cc: Balbir Singh <balbirs@nvidia.com>
Cc: Zenghui Yu (Huawei) <zenghui.yu@linux.dev>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Leon Romanovsky <leon@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/test_hmm.c