]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
iio: light: veml6030: fix IIO device retrieval from embedded device
authorJavier Carrasco <javier.carrasco.cruz@gmail.com>
Fri, 13 Sep 2024 13:18:58 +0000 (15:18 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 22 Oct 2024 13:40:44 +0000 (15:40 +0200)
commit50039aec43a82ad2495f2d0fb0c289c8717b4bb2
tree85f44f285e4c8408a80b04451cd849c35913d241
parentcf95ce2cff8d4e45315121b46219d5c68f97c4c5
iio: light: veml6030: fix IIO device retrieval from embedded device

commit c7c44e57750c31de43906d97813273fdffcf7d02 upstream.

The dev pointer that is received as an argument in the
in_illuminance_period_available_show function references the device
embedded in the IIO device, not in the i2c client.

dev_to_iio_dev() must be used to accessthe right data. The current
implementation leads to a segmentation fault on every attempt to read
the attribute because indio_dev gets a NULL assignment.

This bug has been present since the first appearance of the driver,
apparently since the last version (V6) before getting applied. A
constant attribute was used until then, and the last modifications might
have not been tested again.

Cc: stable@vger.kernel.org
Fixes: 7b779f573c48 ("iio: light: add driver for veml6030 ambient light sensor")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://patch.msgid.link/20240913-veml6035-v1-3-0b09c0c90418@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/light/veml6030.c